Skip to content

Fix generator.py to avoid pathological inlining #28370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2015

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented Sep 12, 2015

Commit 9104a90 fixed the generated
files, but that change would be lost (or require additional manual
intervention) if they are re-generated of if new architectures are
added.

cc #28273

Commit 9104a90 fixed the generated
files, but that change would be lost (or require additional manual
intervention) if they are re-generated of if new architectures are
added.

cc rust-lang#28273
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@killercup
Copy link
Member

In #28354, @alexcrichton asked to comment the inline(never). Could you add a comment here?

and regenerate the platform intrinsics source files.
@ranma42
Copy link
Contributor Author

ranma42 commented Sep 12, 2015

I added the comment and regenerated the sources.

@alexcrichton
Copy link
Member

@bors: r+ 9aa1289

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

⌛ Testing commit 9aa1289 with merge fd212fd...

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

💔 Test failed - auto-win-msvc-64-opt

@dotdash
Copy link
Contributor

dotdash commented Sep 12, 2015

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

⌛ Testing commit 9aa1289 with merge a4f0b48...

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

💔 Test failed - auto-win-msvc-64-opt

@dotdash
Copy link
Contributor

dotdash commented Sep 12, 2015

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 13, 2015

⌛ Testing commit 9aa1289 with merge fd230ff...

bors added a commit that referenced this pull request Sep 13, 2015
Commit 9104a90 fixed the generated
files, but that change would be lost (or require additional manual
intervention) if they are re-generated of if new architectures are
added.

cc #28273
@bors bors merged commit 9aa1289 into rust-lang:master Sep 13, 2015
@ranma42 ranma42 deleted the slow_pat_gen branch September 15, 2015 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants